[asterisk-bugs] [JIRA] (DAHLIN-337) Unable to build DAHDI-Linux 2.9.1 in mock chroot

[Elwin Andriol (JIRA)]

    [ https://issues.asterisk.org/jira/browse/DAHLIN-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=216917#comment-216917 ] 

Elwin Andriol edited comment on DAHLIN-337 at 3/29/14 2:40 PM:
---------------------------------------------------------------

I was able to confirmed this issue by building a .deb package, with pbuilder on Debian Wheezy.

However, instead of [6cebc1c|http://git.asterisk.org/gitweb/?p=dahdi/linux.git;a=commitdiff;h=6cebc1c1fb12cc0661f3810ef47ad33206b2e398], it is git commit [7ce8498|http://git.asterisk.org/gitweb/?p=dahdi/linux.git;a=commitdiff;h=7ce849846502ff9d5a6a7a95cf89a7f23c5680ef] that is the actual cause of the problem.

It issue is not specific to any OS or building environment. It's in fact a series of refactoring mistakes in *drivers/dahdi/firmware/Makefile*. The Makefile is calling the *build_tools/install_firmware* script in order to install firmware. The install_firmware scripts expects the DESTDIR variable (essentially you installation prefix) as its third parameter, but the Makefile only supplies 2 parameters on each invocation.

As long as things are being installed in the system's root directory, this issue does not show because DESTDIR is an empty variable in that case. It is nonetheless a serious bug that will cause trouble for anybody involved in packaging DAHDI-linux.


was (Author: e.andriol):
I was able to confirmed this issue by building a .deb package, with pbuilder on Debian Wheezy.

However, git commit [7ce8498|http://git.asterisk.org/gitweb/?p=dahdi/linux.git;a=commitdiff;h=7ce849846502ff9d5a6a7a95cf89a7f23c5680ef] is the actual cause of this problem instead.

It issue is not specific to any OS or building environment. It's in fact a series of refactoring mistakes in *drivers/dahdi/firmware/Makefile*. The Makefile is calling the *build_tools/install_firmware* script in order to install firmware. The install_firmware scripts expects the DESTDIR variable (essentially you installation prefix) as its third parameter, but the Makefile only supplies 2 parameters on each invocation.

As long as things are being installed in the system's root directory, this issue does not show because DESTDIR is an empty variable in that case. It is nonetheless a serious bug that will cause trouble for anybody involved in packaging DAHDI-linux.

> Unable to build DAHDI-Linux 2.9.1 in mock chroot
> ------------------------------------------------
>
>                 Key: DAHLIN-337
>                 URL: https://issues.asterisk.org/jira/browse/DAHLIN-337
>             Project: DAHDI-Linux
>          Issue Type: Bug
>      Security Level: None
>          Components: General
>         Environment: Both Fedora 20 and CentOS 6.5 Koji/mock chroots
>            Reporter: Anthony Messina
>            Assignee: Russ Meyerriecks
>         Attachments: dahdi-linux-2.9.1-hotplug-install-fix.diff
>
>
> Unfortunately, after
> http://git.asterisk.org/gitweb/?p=dahdi/linux.git;a=commitdiff;h=6cebc1c1fb12cc0661f3810ef47ad33206b2e398
> I am unable to build DAHDI-Linux in a mock chroot for packaging purposes.  I 
> believe this is related to the Makefile calling install_firmware with only 2 
> args, where install_firmware is a shell script with DESTDIR set to $3, which 
> is empty.
> In this case, the DESTDIR evaluates to "/usr/lib/hotplug/firmware", rather 
> than "<buildroot_destdir>/usr/lib/hotplug/firmware".
> make -C drivers/dahdi/firmware hotplug-install 
> DESTDIR=/builddir/build/BUILDROOT/dahdi-linux-2.9.1-1.fc20.x86_64 
> HOTPLUG_FIRMWARE=yes
> make[1]: Entering directory `/builddir/build/BUILD/dahdi-
> linux-2.9.1/drivers/dahdi/firmware'
> mkdir -p /builddir/build/BUILDROOT/dahdi-
> linux-2.9.1-1.fc20.x86_64/usr/lib/hotplug/firmware
> mkdir -p /builddir/build/BUILDROOT/dahdi-
> linux-2.9.1-1.fc20.x86_64/lib/firmware
> Installing dahdi-fw-oct6114-032.bin to hotplug firmware directories
> install: cannot create regular file '/usr/lib/hotplug/firmware': No such file 
> or directory
> make[1]: *** [hotplug-install] Error 1
> make[1]: Leaving directory `/builddir/build/BUILD/dahdi-
> linux-2.9.1/drivers/dahdi/firmware'
> make: *** [install-firmware] Error 2



--
This message was sent by Atlassian JIRA
(v6.2#6252)