[asterisk-bugs] [JIRA] (ASTERISK-23459) [patch]Incorrect check for key field and NULL column values in update_odbc

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=216408#comment-216408 ] 

Rusty Newton edited comment on ASTERISK-23459 at 3/11/14 6:33 PM:
------------------------------------------------------------------

Thanks! You can go ahead and post your patch on Reviewboard:

[Instructions on Code Review can be found at this link|https://wiki.asterisk.org/wiki/display/AST/Code+Review]

Once you create a reviewboard entry, post the reviewboard link on here. Thanks!


was (Author: rnewton):
Thanks! You can go ahead and post your patch on Reviewboard:

[Instructions on Code Review can be found at this link|https://wiki.asterisk.org/wiki/display/AST/Code+Review]


> [patch]Incorrect check for key field and NULL column values in update_odbc
> --------------------------------------------------------------------------
>
>                 Key: ASTERISK-23459
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23459
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_config_odbc
>    Affects Versions: 11.8.1
>            Reporter: zvision
>            Severity: Minor
>         Attachments: res_config_odbc.diff
>
>
> The function update_odbc has two small issues:
> 1. It checks for existence of the first column from the parameter list
>     instead of the existence of a key field used in the WHERE clause.
>     The error message is correct, just the column used for the check is not.
> 2. The check for NULL integer column value examines a column name
>      instead of a column value for an empty string.
> The patch attached corrects both issues and also permits the first column
> in the list to take a NULL value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)