[asterisk-bugs] [JIRA] (ASTERISK-23459) Incorrect check for key field and NULL column values in update_odbc

[zvision (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=216304#comment-216304 ] 

zvision commented on ASTERISK-23459:
------------------------------------

This issue was triggered by connecting an Asterisk to a PostgreSQL realtime SIP peers via ODBC. When the port column in sipregs (sippeers) table is defined as a nullable integer, during deregistration Asterisk tries to put an empty string into the port column. It would be no problem, if the code worked as expected - but due to these bugs, no NULL is substitued in place of an empty string.
I know this is a general issue, but just wanted to provide a real-world use case for this bug report.

> Incorrect check for key field and NULL column values in update_odbc
> -------------------------------------------------------------------
>
>                 Key: ASTERISK-23459
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23459
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_config_odbc
>    Affects Versions: 11.8.1
>            Reporter: zvision
>            Severity: Minor
>         Attachments: res_config_odbc.diff
>
>
> The function update_odbc has two small issues:
> 1. It checks for existence of the first column from the parameter list
>     instead of the existence of a key field used in the WHERE clause.
>     The error message is correct, just the column used for the check is not.
> 2. The check for NULL integer column value examines a column name
>      instead of a column value for an empty string.
> The patch attached corrects both issues and also permits the first column
> in the list to take a NULL value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)