[asterisk-bugs] [JIRA] (ASTERISK-23420) Memory leak in manager_add_filter function in manager.c

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=216133#comment-216133 ] 

Matt Jordan commented on ASTERISK-23420:
----------------------------------------

Patch looks correct to me, since the various filters containers own the reference of the thing linked into them. Nice catch!

> Memory leak in manager_add_filter function in manager.c
> -------------------------------------------------------
>
>                 Key: ASTERISK-23420
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23420
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>    Affects Versions: 11.8.0
>            Reporter: Etienne Lessard
>            Severity: Minor
>         Attachments: manager_eventfilter_leak
>
>
> The title says it all.
> If you have a section in manager.conf with an eventfilter option, when the manager config is reloaded, then a leak occurs (i.e. the reference to new_filter will never reach 0).
> It's missing an ao2_ref(new_filter, -1) after the call to ao2_t_link.



--
This message was sent by Atlassian JIRA
(v6.2#6252)