[asterisk-bugs] [JIRA] (ASTERISK-23951) format_mp3 fails to build if mp3lib was not downloaded

[Tzafrir Cohen (JIRA)]

Tzafrir Cohen created ASTERISK-23951:
----------------------------------------

             Summary: format_mp3 fails to build if mp3lib was not downloaded
                 Key: ASTERISK-23951
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23951
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Addons/format_mp3
    Affects Versions: 11.10.2
            Reporter: Tzafrir Cohen
            Severity: Minor


I'm working on a a package of Asterisk. It originally had:

menuselect/menuselect --enable-category MENUSELECT_ADDONS

contrib/scripts/get_mp3_source.sh

I wanted to avoid the latter as I don't want to download at build time and thus removed it. The result is:

   [CC] format_mp3.c -> format_mp3.o
format_mp3.c:39:24: error: mp3/mpg123.h: No such file or directory
format_mp3.c:40:24: error: mp3/mpglib.h: No such file or directory
format_mp3.c:52: error: field 'mp' has incomplete type
format_mp3.c: In function 'mp3_open':
format_mp3.c:102: warning: implicit declaration of function 'InitMP3'
format_mp3.c: In function 'mp3_close':
format_mp3.c:111: warning: implicit declaration of function 'ExitMP3'
format_mp3.c: In function 'mp3_squeue':
format_mp3.c:126: warning: implicit declaration of function 'decodeMP3'
format_mp3.c:127: error: 'MP3_OK' undeclared (first use in this function)
format_mp3.c:127: error: (Each undeclared identifier is reported only once
format_mp3.c:127: error: for each function it appears in.)
format_mp3.c: In function 'mp3_dqueue':
format_mp3.c:139: error: 'MP3_OK' undeclared (first use in this function)
format_mp3.c: In function 'mp3_queue':
format_mp3.c:159: error: 'MP3_OK' undeclared (first use in this function)
format_mp3.c:167: error: 'MP3_ERR' undeclared (first use in this function)
format_mp3.c: In function 'load_module':
format_mp3.c:322: warning: implicit declaration of function 'InitMP3Constants'
make[1]: *** [format_mp3.o] Error 1
make: *** [addons] Error 2

The lack of mp3 library should be detected and the build should not be attempted, IMHO.



--
This message was sent by Atlassian JIRA
(v6.2#6252)