[asterisk-bugs] [JIRA] (ASTERISK-23790) [patch] - SIP From headers longer than 256 characters result in dropped call and 'No closing bracket' warnings.

[uniken1 (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=219687#comment-219687 ] 

uniken1 commented on ASTERISK-23790:
------------------------------------

I install my production system by yum.
Now I deploy new clean CentOS 6.5 and asterisk from sources.

This output before patching:
[Jun 20 07:53:33] WARNING[29701]: sip/reqresp_parser.c:1061 get_in_brackets_full: No closing bracket found in '...
[Jun 20 07:53:33] NOTICE[29701]: chan_sip.c:16853 check_user_full: From address missing 'sip:', using it anyway
[Jun 20 07:53:33] WARNING[29701]: sip/reqresp_parser.c:1061 get_in_brackets_full: No closing bracket found in '...
[Jun 20 07:53:33] WARNING[29701]: chan_sip.c:16038 get_destination: Not a SIP header (<sip:2058648)?
[Jun 20 07:53:33] WARNING[29701]: sip/reqresp_parser.c:1061 get_in_brackets_full: No closing bracket found in '...
[Jun 20 07:53:33] NOTICE[29701]: chan_sip.c:16853 check_user_full: From address missing 'sip:', using  it anyway
[Jun 20 07:53:33] WARNING[29701]: sip/reqresp_parser.c:1061 get_in_brackets_full: No closing bracket found in '<...
[Jun 20 07:53:33] WARNING[29701]: chan_sip.c:16038 get_destination: Not a SIP header (<sip:2058648)?

Then patching
[root at as21448 asterisk-1.8.26.1]# patch -p0 < chan_sip-large-from-header-1.8.patch
patching file channels/chan_sip.c
Hunk #1 succeeded at 16809 (offset -43 lines).
Hunk #2 succeeded at 16897 (offset -43 lines).

And I add some empty lines at begin of file chan_sip.c

Output after patching:
[Jun 20 08:02:12] WARNING[1440]: sip/reqresp_parser.c:1061 get_in_brackets_full: No closing bracket found in '...
[Jun 20 08:02:12] WARNING[1440]: chan_sip.c:16043 get_destination: Not a SIP header (<sip:2058648)?
[Jun 20 08:02:12] WARNING[1440]: sip/reqresp_parser.c:1061 get_in_brackets_full: No closing bracket found in '...
[Jun 20 08:02:12] WARNING[1440]: chan_sip.c:16043 get_destination: Not a SIP header (<sip:2058648)?

> [patch] - SIP From headers longer than 256 characters result in dropped call and 'No closing bracket' warnings.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23790
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23790
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 1.8.26.1, 12.2.0
>         Environment: CentOS 6.5
>            Reporter: uniken1
>            Assignee: uniken1
>         Attachments: chan_sip-large-from-header-11.patch, chan_sip-large-from-header-1.8.patch, myDebugLog
>
>
> [Edit by Rusty - The bracket is present in the packet - Asterisk receives it but stops parsing the From header before it gets to the bracket. I'm guessing due to a character length limit somewhere]
> Asterisk drop call from trunk when SIP display info pressent in SIP invite packet. When I tcpdump packets I found that Asterisk incorrect parsing SIP packet. It said "No closing bracket found...", but bracket realy exists.
> Check screens:
> http://i64.fastpic.ru/big/2014/0526/cd/207e0e4f6924812d1bcdbe2b5283eacd.png
> http://i64.fastpic.ru/big/2014/0526/ab/5764bee7a86881b6a29065396d554cab.png



--
This message was sent by Atlassian JIRA
(v6.2#6252)