[asterisk-bugs] [JIRA] (ASTERISK-23908) [patch]When using FEC error correction, asterisk tries considers negative sequence numbers as missing

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=219679#comment-219679 ] 

Matt Jordan commented on ASTERISK-23908:
----------------------------------------

Very quick comment on the patch:
# Put spaces between {{if}} and {{(}}.
# Use {{ { }} and {{ } }} even for single line conditionals.

I haven't looked at the udptl code in a long time, so I can't comment yet on the patch itself... but that's what review board is for :-)

> [patch]When using FEC error correction, asterisk tries considers negative sequence numbers as missing
> -----------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23908
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23908
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/UDPTL
>    Affects Versions: 11.10.1
>            Reporter: Torrey Searle
>         Attachments: t38_fec_issue.pcap, udptl_fec.patch
>
>
> When using FEC error correction with span=3 and entries=4 asterisk will try to repair in packet with sequence number 5 because it will see that packet -4 is missing.  The result is that Asterisk will forward garbage packets that can possibly kill the fax.
> Attatched is an example pcap showing this issue and a patch to resolve this issue



--
This message was sent by Atlassian JIRA
(v6.2#6252)