[asterisk-bugs] [JIRA] (ASTERISK-23897) Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=219609#comment-219609 ] 

Rusty Newton commented on ASTERISK-23897:
-----------------------------------------

[~patrol-cz] For the next step, please follow the [Code Review process|https://wiki.asterisk.org/wiki/display/AST/Code+Review] and put the patch on reviewboard.

Thanks Pavel!

> Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments
> -----------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23897
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23897
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_dahdi
>    Affects Versions: 11.10.2
>         Environment: An Asterisk system interconnected with either MD110 release BC13 or Avaya Definity (release Unknown)
>            Reporter: Pavel Troller
>         Attachments: pri.diff
>
>
> The change introduced in revision 413765 limits opening the media channel and sending the PROGRESS control frame only to cases, when the Progress Indication with value "Inband Info now available" is present in the SETUP ACK message. However, there are exchanges (like these mentioned in the "environment" section), which don't send this PI in SETUP ACK, but they send regular dial tone. Now the dial tone (and any subsequent audio information until some progress indication is received from the PBX) cannot be heard.
>   I understand, that the change was necessary to fix another problem, but it introduces this one, so from my point of view, it's a regression.
>   My proposed solution is to introduce a new config option. I've called it "alwayssendprogress" and it's a binary no/yes option. In the "no" status, it keeps the new behaviour in place. In the "yes" status, it restores the old one.
> A better naming is possible, any proposals are welcome.
>   The supplied patch was tested on current V11 SVN and it seems to be working as expected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)