[asterisk-bugs] [JIRA] (SS7-52) PATCH] Encode additional chars in number (0xC)

[Kaloyan Kovachev (JIRA)]

    [ https://issues.asterisk.org/jira/browse/SS7-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=219601#comment-219601 ] 

Kaloyan Kovachev commented on SS7-52:
-------------------------------------

This is fixed in libss7 v2.0:
char2digit() accepts both lower case and capital chars (* and # in addition for E and F) , while digit2char() always return capital - ABCD and '*' + '#'

The change is backward compatible, so if it is necessary those two functions can be copied to v1 too.

> PATCH] Encode additional chars in number (0xC)
> ----------------------------------------------
>
>                 Key: SS7-52
>                 URL: https://issues.asterisk.org/jira/browse/SS7-52
>             Project: LibSS7
>          Issue Type: Bug
>      Security Level: None
>          Components: General, NewFeature
>            Reporter: Rafał Ramocki
>            Assignee: mattf
>
> Hi,
> Im using asterisk as a VOIP<->PSTN gateway with E1 Trunk and SS7 signaling. When from voip is called emergency number (in europe it is 112) i have to pass it throu SS7 in following format:
> XXCYYY112
> Where:
> XX is a direction number (in US it will be number representing state)
> C - is hexadecimal "C" or 0xC
> YYY it is numer representing emergency office in "state"
> 112 is our emergency number
> EX: 15C100112 
> But libss7 does not allow to use 0xc. For now only 0-9 and 15 (#) are allowed. I Found in RFC3966 (5.1.3) information that in global traffic only 0-9 are allowed, but it is possible to encode additional characters. In accordance with E.164, these may not be included in global numbers.  Their meaning in local numbers is not defined here, but they are not prohibited. So to compile with polish regulations I addred support of 0xc. But i supose it might be good idea to add all 0xa - 0xd. I believe that 0xe might be encoded as asterisk, but i didn't found 100% sure comfirmation about this last theory.
> Below is patch for 0xc.
> --- libss7-1.0.2/isup.c	2008-08-09 18:54:23.000000000 +0200
> +++ libss7-1.0.2.new/isup.c	2011-07-03 21:21:44.000000000 +0200
> @@ -216,6 +216,8 @@
>  			return 8;
>  		case '9':
>  			return 9;
> +		case 'c':
> +			return 0xc;
>  		case '#':
>  			return 0xf;
>  		default:
> @@ -246,6 +248,8 @@
>  			return '8';
>  		case 9:
>  			return '9';
> +		case 12:
> +			return 'c';
>  		case 15:
>  			return '#';
>  		default:



--
This message was sent by Atlassian JIRA
(v6.2#6252)