[asterisk-bugs] [JIRA] (ASTERISK-23896) res_pjsip_t38: T.38 Framehook prevents local native bridge

[Matt Jordan (JIRA)]

Matt Jordan created ASTERISK-23896:
--------------------------------------

             Summary: res_pjsip_t38: T.38 Framehook prevents local native bridge
                 Key: ASTERISK-23896
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23896
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Bridges/bridge_native_rtp, Resources/res_pjsip_t38
    Affects Versions: 12.3.0
            Reporter: Matt Jordan


While investigating why the SIP native T.38 test was failing post https://reviewboard.asterisk.org/r/3585, I discovered that the PJSIP native T.38 test wasn't really ... native.

Due to using a framehook to read/write T.38 data, the {{pjsip}} channel driver will never allow {{bridge_native_rtp}} to be used.

A few things need to be cleaned up:
# We probably shouldn't rely on a framehook to do all reading/writing. Image is a valid media stream and should be stored in {{chan_pjsip_pvt-media}} - and read/written from {{chan_pjsip}}
# {{chan_pjsip_get_rtp_peer}} should be updated to check the state of T.38 negotiation. If T.38 has been negotiated successfully, we need to forbid remote bridging (which was the bug in the {{chan_sip}} code). This is particularly needed as the gateway framehook will soft hangup a channel, causing a bridge reconfigure (and this function) to be called



--
This message was sent by Atlassian JIRA
(v6.2#6252)