[asterisk-bugs] [JIRA] (ASTERISK-23836) JACK_HOOK with more than 8Khz

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=219375#comment-219375 ] 

Matt Jordan commented on ASTERISK-23836:
----------------------------------------

>From a cursory glance, the patch could use some clean up before going up for peer review. Please review the [Coding Guidelines|https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines] before posting it for review.

Some obvious things:
# Don't use your name in comments
# Don't leave commented out code
# Don't use {{//}} for comments
# Leaving {{0 != 0}} in a conditional is ... not useful? :-)

Once the patch conforms to the coding guidelines, please post it for peer review on review board. You can find instructions on doing so here:

https://wiki.asterisk.org/wiki/display/AST/Code+Review

> JACK_HOOK with more than 8Khz
> -----------------------------
>
>                 Key: ASTERISK-23836
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23836
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_jack
>    Affects Versions: SVN
>         Environment: Ubuntu 14.04 using 11.7 and trunk in combination with jackd and puredata.
>            Reporter: Dennis Guse
>            Severity: Minor
>         Attachments: patch-app_jack.c
>
>
> So far app_jack is limited to 8Khz only.
> The following patch adds support for dynamic sampling rates using information provided by the channel.
> Checked with Linphone and Ekiga using G.711 and G.722 on Ubuntu 14.04 64bit.
> Limitations:
> * Information, i.e. sampling rate, is taken from channel during initialization as audiohook does not provide this information then. Audiohook.internal_sampl_rate is set later, but no callback is called.
> * Frame.datalen is computed using rate / 50 assuming a ptime of 20ms.
> There is no internal API available to determine datalen for a SLINxx.
> * Ringbuffer size is a DEFINE and thus must be quite big to be able to cope with 16Khz+
> PS: This bug report is a duplicate of ASTERISK-20696



--
This message was sent by Atlassian JIRA
(v6.2#6252)