[asterisk-bugs] [JIRA] (ASTERISK-23823) [patch] Option to keep queuerules in realtime

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=219047#comment-219047 ] 

Matt Jordan commented on ASTERISK-23823:
----------------------------------------

A few comments:
# New features should be made against Asterisk trunk. As this issue was made against Asterisk 1.8, I'm assuming the patch was made against that version of Asterisk. Please provide a patch that merges cleanly with Asterisk trunk.
# Taking a quick cursory glance at the patch, there appear to be numerous [coding guideline violations|https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines]. Please update the patch per the guidelines on the wiki before submitting it for inclusion.
# Subtle changes in {{app_queue}} tend to result in regressions. This is particularly true when realtime is involved. What testing was done for this new feature? Can tests be written for the Asterisk Test Suite that verify this feature?

> [patch] Option to keep queuerules in realtime
> ---------------------------------------------
>
>                 Key: ASTERISK-23823
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23823
>             Project: Asterisk
>          Issue Type: New Feature
>      Security Level: None
>          Components: Applications/app_queue
>    Affects Versions: 1.8.27.0
>            Reporter: Michael K.
>            Severity: Minor
>         Attachments: app_queue.patch, queue_rules.sql
>
>
> This patch the ability (optional) to keep queuerules in realtime (rules would be loaded from file too)
> To test add to queuerules.conf :
> [general]
> realtime_rules = yes
> and add the realtime setting to extconfig.conf, for example in my case it's mysql and it looks like(will attach the .sql with create for table):
> queue_rules => mysql,asterisk,queue_rules
> in table as you can see you need to specify rule name and as in regular rules you can use relative setings for min and max (with "-" and "+", e.g. "+100")
> If you use realtime, the rules will be always reloaded (no cache option here), in other words it would delete all rules and re-add them from realtime and file. It's important to understand that with realtime on it would reload rules from file doesn't matter if file was or was not change.
> While with the option off it would act exactly like it was before patch (file would not be reloaded if it was not changed)



--
This message was sent by Atlassian JIRA
(v6.2#6252)