[asterisk-bugs] [JIRA] (ASTERISK-23985) PresenceState Action response does not contain ActionID; duplicates Message Header

[Matt Jordan (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-23985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Jordan closed ASTERISK-23985.
----------------------------------

    Resolution: Fixed

> PresenceState Action response does not contain ActionID; duplicates Message Header
> ----------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23985
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23985
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/ManagerInterface
>    Affects Versions: 11.10.2, 12.3.2
>            Reporter: Matt Jordan
>            Assignee: Matt Jordan
>
> The handler for the PresenceState action has two issues:
> # It duplicates the {{Message}} key:
> {code}
> 	if (!ast_strlen_zero(message)) {
> 		snprintf(message_header, sizeof(message_header),
> 				"Message: %s\r\n", message);
> 	}
> 	astman_append(s, "Message: Presence State\r\n"
> 			"State: %s\r\n"
> 			"%s"
> 			"%s"
> 			"\r\n",
> 			ast_presence_state2str(state),
> 			subtype_header,
> 			message_header);
> 	return 0;
> {code}
> # It fails to return the ActionID (Or the required "Response: Success" header) to the invoker of the action.
> Unfortunately, renaming the {{Message:}} header would be a backwards incompatible change. We should either suck it up and do that (thus bumping AMI to v3), or else add a preferred header for the presence message, add a deprecation notice for the other header, and make the backwards incompatible change at a latter time when we have more things to adjust.



--
This message was sent by Atlassian JIRA
(v6.2#6252)