[asterisk-bugs] [JIRA] (ASTERISK-24018) chan_sip: port incorrectly incremented for RTCP ICE candidates in SDP answer

[Matt Jordan (JIRA)]

Matt Jordan created ASTERISK-24018:
--------------------------------------

             Summary: chan_sip: port incorrectly incremented for RTCP ICE candidates in SDP answer
                 Key: ASTERISK-24018
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24018
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_sip/WebSocket
    Affects Versions: 11.10.0
            Reporter: Badalian Vyacheslav
            Assignee: Matt Jordan
            Severity: Critical


sipml5 does not work trougth NAT becouse it's can connect to second candidate port if ice is on. You have small logic bug. 
1. You have 2 candidates - port X and port Y.
2. Y = X+1. 
3. Also you have ICE in reply to client: X and Y + 1. Y already +1! 
Result: In ICE answer you have X and X+2.

Its wrong. Port before NAT and after NAT must be some!

before patch:
{code}
a=candidate:Had86137 1 UDP 2130706431 10.216.97.55 54982 typ host
a=candidate:S5bc2e2f0 1 UDP 1694498815 91.194.226.240 54982 typ srflx
a=candidate:Had86137 2 UDP 2130706430 10.216.97.55 54983 typ host
a=candidate:S5bc2e2f0 2 UDP 1694498814 91.194.226.240 54984 typ srflx
{code}

After:
{code}
a=candidate:Had86137 1 UDP 2130706431 10.216.97.55 54982 typ host
a=candidate:S5bc2e2f0 1 UDP 1694498815 91.194.226.240 54982 typ srflx
a=candidate:Had86137 2 UDP 2130706430 10.216.97.55 54983 typ host
a=candidate:S5bc2e2f0 2 UDP 1694498814 91.194.226.240 54983 typ srflx
{code}

Patch:
\[EDIT\]: mjordan

We cannot accept patches inline. Please attach the patch in unified diff format after signing a license agreement.



--
This message was sent by Atlassian JIRA
(v6.2#6252)