[asterisk-bugs] [JIRA] (ASTERISK-24009) Disable T.38 (t38pt_udptl=no) reject T.38 REINVITE with 488 Not acceptable here

[Matt Jordan (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-24009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Jordan closed ASTERISK-24009.
----------------------------------

    Resolution: Not A Bug

That change was intentional. Quoting from the review:

{quote}
* Nearly all SDP errors will result in a '488 Not Acceptable Here' response, rather than an attempt to use some part of the offer/answer presented in the SDP.
{quote}

There was a lengthy discussion of this on the -dev list. Today, {{chan_sip}} does not have a mechanism in its SDP generation code to decline media streams that it doesn't understand. Because of that, it has to treat offers as an "all or nothing" - otherwise, it will negotiate back things that it doesn't understand and is not equipped to handle.

Relevant asterisk-dev discussion:

http://lists.digium.com/pipermail/asterisk-dev/2012-May/055365.html

> Disable T.38 (t38pt_udptl=no) reject T.38 REINVITE with 488 Not acceptable here
> -------------------------------------------------------------------------------
>
>                 Key: ASTERISK-24009
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24009
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/T.38
>    Affects Versions: 1.8.28.2
>            Reporter: nicolasom
>         Attachments: trace.cap
>
>
> Incoming call offers T.38,alaw,ulaw for fax. Is rejected if T.38 is disabled instead of accept alaw or ulaw codecs.
> I think the problem is in function process_sdp in chan_sip.c:
> {code}
> 9531 	if (initialize_udptl(p)) {
> 9532 		ast_log(LOG_WARNING, "Rejecting offer with image stream due to UDPTL initialization failure\n");
> 9533 		return -1;
> 9534 	}
> {code}
> The function initialize_udptl return 1 if T.38 is disabled. I would change 'return -1' with 'continue' for ignore T.38 if is disabled or the initialization failed.
> In the past works. This revision changes the behavior:
> http://svnview.digium.com/svn/asterisk/branches/1.8?view=revision&revision=368218



--
This message was sent by Atlassian JIRA
(v6.2#6252)