[asterisk-bugs] [JIRA] (ASTERISK-24009) Disable T.38 (t38pt_udptl=no) reject T.38 REINVITE with 488 Not acceptable here

[nicolasom (JIRA)]

nicolasom created ASTERISK-24009:
------------------------------------

             Summary: Disable T.38 (t38pt_udptl=no) reject T.38 REINVITE with 488 Not acceptable here
                 Key: ASTERISK-24009
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24009
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_sip/T.38
    Affects Versions: 1.8.28.2
            Reporter: nicolasom


Incoming call offers T.38,alaw,ulaw for fax. Is rejected if T.38 is disabled instead of accept alaw or ulaw codecs.

I think the problem is in function process_sdp in chan_sip.c:
{code}
9531 	if (initialize_udptl(p)) {
9532 		ast_log(LOG_WARNING, "Rejecting offer with image stream due to UDPTL initialization failure\n");
9533 		return -1;
9534 	}
{code}

The function initialize_udptl return 1 if T.38 is disabled. I would change 'return -1' with 'continue' for ignore T.38 if is disabled or the initialization failed.

In the past works. This revision changes the behavior:
http://svnview.digium.com/svn/asterisk/branches/1.8?view=revision&revision=368218



--
This message was sent by Atlassian JIRA
(v6.2#6252)