[asterisk-bugs] [JIRA] (ASTERISK-23897) [patch]Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments

[Pavel Troller (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-23897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Troller updated ASTERISK-23897:
-------------------------------------

    Status: Waiting for Feedback  (was: Waiting for Feedback)

Sorry for being late. I've seen "Ship it!" on reviewboard and I thought that it's the end of the story :-). It's my first participation here in reviewboard and I'm not experienced enough.
  Regarding the patch: It fixes the problem in about 90% of cases. I know of at least one case, where it doesn't work - using partial en-bloc  (i.e. at least one digit dialed in SETUP), followed by digits sent in overlap mode, and the dialed number being routed in the cooperating PBX into another one (transit call) with the same problem (very often case in complex networks like power plant nets etc.).  In such a case, you have to hear a dial tone from that exchange, and you don't hear it, because the second PBX also doesn't send PI in SETUP ACK and the first one simply doesn't send you anything after seizing the line. The original patch is fixing also this case.
  With regards,
  Pavel

> [patch]Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments
> ------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23897
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23897
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_dahdi
>    Affects Versions: 11.10.2
>         Environment: An Asterisk system interconnected with either MD110 release BC13 or Avaya Definity (release Unknown)
>            Reporter: Pavel Troller
>            Assignee: Pavel Troller
>         Attachments: jira_asterisk_23897_v11.patch, pri.diff
>
>
> The change introduced in revision 413765 limits opening the media channel and sending the PROGRESS control frame only to cases, when the Progress Indication with value "Inband Info now available" is present in the SETUP ACK message. However, there are exchanges (like these mentioned in the "environment" section), which don't send this PI in SETUP ACK, but they send regular dial tone. Now the dial tone (and any subsequent audio information until some progress indication is received from the PBX) cannot be heard.
>   I understand, that the change was necessary to fix another problem, but it introduces this one, so from my point of view, it's a regression.
>   My proposed solution is to introduce a new config option. I've called it "alwayssendprogress" and it's a binary no/yes option. In the "no" status, it keeps the new behaviour in place. In the "yes" status, it restores the old one.
> A better naming is possible, any proposals are welcome.
>   The supplied patch was tested on current V11 SVN and it seems to be working as expected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)