[asterisk-bugs] [JIRA] (ASTERISK-23235) pjsip transport/tos interpreted differently than endpoint/tos_audio

[George Joseph (JIRA)]

George Joseph created ASTERISK-23235:
----------------------------------------

             Summary: pjsip transport/tos interpreted differently than endpoint/tos_audio
                 Key: ASTERISK-23235
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23235
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Resources/res_pjsip
    Affects Versions: 12.0.0
         Environment: Fedora 20 x86_64
            Reporter: George Joseph
            Severity: Minor


It appears that setting tos in a transport actually sets the DSCP field in the IP header for SIP packets whereas setting tos_audio in an endpoint sets the old tos field in the IP header for RTP packets.

Example...

{code}
[sometransport]
type=transport
tos=12
{code}

results in 

{code}
Differentiated Services Field: 0x30 (DSCP 0x0c: Assured Forwarding 12; ECN: 0x00: Not-ECT (Not ECN-Capable Transport))
{code}

Note that the DSCP is set to 0x0c (12 dec)

BUT

{code}
[someendpoint]
type=endpoint
tos_audio=12
{code}

results in

{code}
Differentiated Services Field: 0x0c (DSCP 0x03: Unknown DSCP; ECN: 0x00: Not-ECT (Not ECN-Capable Transport))
{code}

Note that in this case, the entire field is set to 0x0c (12 dec) and the DSCP is set to an unknown DSCP.

Ideally the name of the parameter should match the actual field set.  If it's 'tos' then it should set the old-style tos field in the IP header.  If it's 'dscp' it should set the new-style DSCP field in the IP header.

I vote for changing them both to dscp and having them set the new-style DSCP header field.




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira