[asterisk-bugs] [JIRA] (ASTERISK-23214) chan_sip WARNING message 'We are requesting SRTP for audio, but they responded without it' is ambiguous and wrong in some cases

[Rusty Newton (JIRA)]

Rusty Newton created ASTERISK-23214:
---------------------------------------

             Summary: chan_sip WARNING message 'We are requesting SRTP for audio, but they responded without it' is ambiguous and wrong in some cases
                 Key: ASTERISK-23214
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23214
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_sip/General
    Affects Versions: 12.0.0, 11.7.0, 1.8.25.0, SVN
            Reporter: Rusty Newton


Following the tutorial here: https://wiki.asterisk.org/wiki/display/AST/Secure+Calling+Tutorial

At the point where you have Blink call Asterisk, but have not yet enabled "encryption=yes" for the peer, the call will fail and you'll see this message on the Asterisk CLI:

{code}
[Jan 29 14:33:23] WARNING[10930][C-00000003]: chan_sip.c:10538 process_sdp: We are requesting SRTP for audio, but they responded without it!
{code}

This happens when the remote client, Blink sends SDP to Asterisk including SRTP offers, but Asterisk has encryption=no. Therefore the message makes no sense as "We" will likely be interpreted by the user as Asterisk itself.

The message should be more explicit. Mark Michelson mentioned this message probably exists in code used commonly to various scenarios, so maybe something like "One party in the call has requested SRTP, but the other party is not capable."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira