[asterisk-bugs] [JIRA] (ASTERISK-22988) [patch]T38 , SIP 488 after Rejecting image media offer due to invalid or unsupported syntax

[adomjan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=214296#comment-214296 ] 

adomjan commented on ASTERISK-22988:
------------------------------------

I've got in response:

(null)(null)m=....


What's happen if the offer->decline_m_line is NULL? I didn't checked the add_content() and the ather called functions, they add something to response string.

so I suggest
if (offer->decline_m_line)
   add_content(resp, offer->decline_m_line);

I have not seen initial value set for offer->decline_m_line it should be also check...
                
> [patch]T38 , SIP 488 after Rejecting image media offer due to invalid or unsupported syntax
> -------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-22988
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22988
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/T.38
>    Affects Versions: 1.8.24.0, 11.6.0, 12.0.0-beta2
>            Reporter: adomjan
>            Severity: Minor
>         Attachments: chan_sip.c-decline-rtp_avp-rtp_savp-image-sdp_ignore_null_content.patch, debug_afterpatch.txt, debug.txt
>
>
> adomjan reported an issue that I pulled out of comments on ASTERISK-22262.
> {quote}
> [Nov 29 14:50:43] WARNING[32504][C-000000d3] chan_sip.c: Rejecting image media offer due to invalid or unsupported syntax: image 27598 RTP/AVP t38
> [Nov 29 14:50:43] VERBOSE[32504][C-000000d3] chan_sip.c:
> <--- Reliably Transmitting (no NAT) to 10.250.253.3:5060 --->
> SIP/2.0 488 Not acceptable here
> the problem is the RTP/AVP and RTP/SAVP, asterisk should decline it from sdp. I couldn't test my patch today I will, next days.
> {quote}
> and additionally adomjan reports that his patches works for his case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira