[asterisk-bugs] [JIRA] (ASTERISK-23026) Asterisk should send STUN messages using role 'ICE-CONTROLLING' when being offerer of SDP

[Giovanni Bezicheri (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213953#comment-213953 ] 

Giovanni Bezicheri edited comment on ASTERISK-23026 at 1/14/14 2:05 AM:
------------------------------------------------------------------------

The patch has worked! Now webrtc work correctly, Thanks!
I have slightly modified the patch for the 11.7 version.
                
      was (Author: gbezicheri):
    The patch has worked! Now webrtc work correctly, Thanks!
I have slightly modified the patch for the 11.7 version.

--- asterisk-11.7.0.ori/res/res_rtp_asterisk.c  2013-10-23 19:37:15.000000000 +0200
+++ asterisk-11.7.0/res/res_rtp_asterisk.c      2014-01-13 09:16:53.980854622 +0100
@@ -1837,7 +1837,7 @@
        passwd = pj_str(rtp->local_passwd);
 
        /* Create an ICE session for ICE negotiation */
-       if (icesupport && pj_ice_sess_create(&stun_config, NULL, PJ_ICE_SESS_ROLE_UNKNOWN, 2, &ast_rtp_ice_sess_cb, &ufrag, &passwd, &rtp->ice) == PJ_SUCCESS) {
+   if (icesupport && pj_ice_sess_create(&stun_config, NULL, PJ_ICE_SESS_ROLE_CONTROLLING, 2, &ast_rtp_ice_sess_cb, &ufrag, &passwd, &rtp->ice) == PJ_SUCCESS) {
                /* Make this available for the callbacks */
                rtp->ice->user_data = rtp;
 	  				 	 	 	    		  	   		  		
                  
> Asterisk should send STUN messages using role 'ICE-CONTROLLING' when being offerer of SDP
> -----------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23026
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23026
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/General
>    Affects Versions: 12.0.0
>            Reporter: Marko Seidenglanz
>            Assignee: Marko Seidenglanz
>            Severity: Minor
>
> When Asterisk initiates an ICE-based session, then it must send it's STUN check messages using role "ICE-CONTROLLING". Currently it uses "ICE-CONTROLLED". Though the role conflict get's resolved correctly, it does not conform to http://tools.ietf.org/html/rfc5245#section-5.2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira