[asterisk-bugs] [JIRA] (ASTERISK-22924) PJSIP MESSAGE support does not present the contact information on outbound messages

[Kevin Harwell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213572#comment-213572 ] 

Kevin Harwell commented on ASTERISK-22924:
------------------------------------------

I got a bit delete happy :-) and removed too much code that dealt with the 'From' portion.  That's hopefully fixed now (updated the review).

The username portion however does get generated as a GUID, but can be overridden using the 'from_user' option (similar to 'from_domain').  The way it is working now is the 'From' header gets created in res_pjsip using the defaults (username = GUID or 'from_user' if specified, domain = asterisk ip or 'from_domain' if specified).  Those values are used if no 'from' parameter is used in MessageSend.  If however a valid uri is specified in the 'from' parameter then the messaging code overwrites the default values for display name, username, and domain and that is what will be used in the outgoing 'From' header.

Hopefully that is acceptable.  Also the sip: to sips: issue should be resolved as well in the patch under review.  Thanks again for the feedback and testing this out!
                
> PJSIP MESSAGE support does not present the contact information on outbound messages
> -----------------------------------------------------------------------------------
>
>                 Key: ASTERISK-22924
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22924
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_messaging
>    Affects Versions: 12.0.0-beta1
>         Environment: Fedora 19 x86_64
>            Reporter: Anthony Messina
>            Assignee: Kevin Harwell
>            Severity: Minor
>         Attachments: asterisk_transaction_MESSAGE_2013-12-31_no_from_domain.txt, asterisk_transaction_MESSAGE_2014-01-01.txt, pjsip_message_fromdomain.txt
>
>
> When processing SIP MESSAGE requests, PJSIP does not add/retain the contact information of the sender on the outbound message, which makes it difficult for clients to display messages in a usable fashion.  Primarily, the "User Name" portion of the callerid is removed from the "From" header, and the fromdomain/from_domain is replaced with the IP addr of the AOR.  Also, it modifies "sip" to "sips".
> {code}
> From: <sips:testuser at 10.1.2.204>;tag=d3df0476-9b58-4565-b300-8cb7bad5f514
> {code}
> I'll attach pjsip logs for one inbound/outbound circuit where I'm simply sending a MESSAGE to myself.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira