[asterisk-bugs] [JIRA] (ASTERISK-23306) chan_sip: Asterisk creates ACK with empty Route: headers

[Corey Farrell (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-23306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Corey Farrell updated ASTERISK-23306:
-------------------------------------

    Attachment: chan_sip-route.patch

I was able to reproduce this issue using sipp.

The issue happened when:
* No Record-Route was received
* Contact header does not contain ";lr" - causing strict mode.

This caused add_route to add the empty header since {{sip_route_empty}} is false, but {{sip_route_list}} produced an empty string.  

The attached patch causes {{sip_route_list}} to return NULL when formatcli==0, skip > 0 and all hops are skipped.

Another way to fix this would be to make {{sip_route_empty}} into a method that accepts a skip parameter, that way sip_route_empty(1) would be true for a route with one or less hops.
                
> chan_sip: Asterisk creates ACK with empty Route: headers
> --------------------------------------------------------
>
>                 Key: ASTERISK-23306
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23306
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: SVN
>            Reporter: Matt Jordan
>            Assignee: Corey Farrell
>         Attachments: chan_sip-route.patch, typescript.gz
>
>
> When sending an ACK to a 200 OK, {{chan_sip}} is sending a Route: header unpopulated with any value. Hilarity ensues as the device continues to send the 200 OK to Asterisk.
> Example from the attached log file for channel {{SIP/200-00000002}}:
> {noformat}
> --- (11 headers 16 lines) ---
> Transmitting (NAT) to 10.10.6.214:5061:
> ACK sip:200 at 10.10.6.214:5061;ob SIP/2.0
> Via: SIP/2.0/UDP 10.10.9.206:5060;branch=z9hG4bK1d66c404;rport
> Route: 
> Max-Forwards: 70
> From: "F208" <sip:208 at 10.10.9.206>;tag=as7688ab8f
> To: <sip:200 at 10.10.6.214:5061;ob>;tag=575da22f-4f89-40c4-b8f3-6bee207b6f07
> Contact: <sip:208 at 10.10.9.206:5060>
> Call-ID: 5958b06f2925d5a2670f31f86dc90d01 at 10.10.9.206:5060
> CSeq: 102 ACK
> User-Agent: Asterisk PBX (digium)
> Content-Length: 0
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira