[asterisk-bugs] [JIRA] (ASTERISK-23279) Asterisk doesn't support the dynamic payload change in rtp mapping in the 200 OK response

[NITESH BANSAL (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

NITESH BANSAL updated ASTERISK-23279:
-------------------------------------

    Attachment: dynamic_payload_change.patch

Hello,
Here is the fix for this issue.
Explanation:
Asterisk uses the function ast_rtp_codecs_payload_code to find the payload code for a specific format.
For RTPEvent packets, asterisk_format is NULL and rtp_code is 1, ast_rtp_codecs_payload_code calls the function  ""ao2_find(codecs->payloads, &code, OBJ_NOLOCK | OBJ_KEY)"" to find the payload code, this is incorrect, because by default ao2_find will do the search based on payload code instead of rtp_code.
To fix this, i have added a new function "rtp_payload_type_find_nonast_format", which search the codecs->payloads based on the rtp_code.
I request you guys to review this patch.  
                
> Asterisk doesn't support the dynamic payload change in rtp mapping in the 200 OK response
> -----------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23279
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23279
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/RTP
>    Affects Versions: 11.4.0
>         Environment: Debian wheezy amd64
>            Reporter: NITESH BANSAL
>         Attachments: dynamic_payload_change.patch, sip.conf, uac_asterisk.xml, uas_asterisk.xml
>
>
> Scenario:
> Asterisk sends the INVITE proposing alaw and telephone-event, it proposes rtpmap:101 for telephone-event.
> Peer responds with 2xx, it answers with alaw and telephone-event also, but it proposes a different rtpmap number(rtpmap:103) for telephone-event.
> Expected Behaviour: Asterisk should honour the rtpmapping in the response and send DTMF packets using 103 as payload type for DTMF.
> Actual Behaviour: Asterisk sends DTMF packets using payload type 101.
> Regards,
> Nitesh 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira