[asterisk-bugs] [JIRA] (ASTERISK-23026) Asterisk should send STUN messages using role 'ICE-CONTROLLING' when being offerer of SDP

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213595#comment-213595 ] 

Rusty Newton edited comment on ASTERISK-23026 at 2/6/14 7:39 AM:
-----------------------------------------------------------------

The following patch must be applied to res_rtp_asterisk to make outgoing calls to WebRTC capable browsers working. This is necessary due to the following issue in role negotiation:
https://code.google.com/p/webrtc/issues/detail?id=2717&can=4&colspec=ID%20Pri%20Mstone%20ReleaseBlock%20Area%20Status%20Owner%20Summary

[Edit by Rusty Newton - Removing inline patch, since we can't use that without license]
                
      was (Author: markose):
    The following patch must be applied to res_rtp_asterisk to make outgoing calls to WebRTC capable browsers working. This is necessary due to the following issue in role negotiation:
https://code.google.com/p/webrtc/issues/detail?id=2717&can=4&colspec=ID%20Pri%20Mstone%20ReleaseBlock%20Area%20Status%20Owner%20Summary




--- res_rtp_asterisk.c	2014-01-06 10:51:53.624488475 +0100
+++ res_rtp_asterisk.c	2014-01-06 10:59:53.200506272 +0100
@@ -1833,7 +1833,7 @@
 	ast_rtp_instance_set_data(instance, rtp);
 #ifdef HAVE_PJPROJECT
 	/* Create an ICE session for ICE negotiation */
-	if (icesupport && pj_ice_sess_create(&stun_config, NULL, PJ_ICE_SESS_ROLE_UNKNOWN, 2, &ast_rtp_ice_sess_cb, &ufrag, &passwd, NULL, &rtp->ice) == PJ_SUCCESS) {
+	if (icesupport && pj_ice_sess_create(&stun_config, NULL, PJ_ICE_SESS_ROLE_CONTROLLING, 2, &ast_rtp_ice_sess_cb, &ufrag, &passwd, NULL, &rtp->ice) == PJ_SUCCESS) {
 		/* Make this available for the callbacks */
 		rtp->ice->user_data = rtp;
 
                  
> Asterisk should send STUN messages using role 'ICE-CONTROLLING' when being offerer of SDP
> -----------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23026
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23026
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/General
>    Affects Versions: 12.0.0
>            Reporter: Marko Seidenglanz
>            Assignee: Marko Seidenglanz
>            Severity: Minor
>         Attachments: res_rtp_asterisk_ice_role.patch
>
>
> When Asterisk initiates an ICE-based session, then it must send it's STUN check messages using role "ICE-CONTROLLING". Currently it uses "ICE-CONTROLLED". Though the role conflict get's resolved correctly, it does not conform to http://tools.ietf.org/html/rfc5245#section-5.2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira