[asterisk-bugs] [JIRA] (ASTERISK-22992) [patch]Asterisk app_originate doesn't allow setting Caller*ID on the originating channel

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224231#comment-224231 ] 

Matt Jordan commented on ASTERISK-22992:
----------------------------------------

The Asterisk Patch Contribution Process is available on the wiki:

https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process

To summarize:
# Any patch on an improvement can be marshalled through the process by an Asterisk Developer. No one has done that, so the issue is open.
# The contributor could, if they so choose, push the patch through the process by submitting it for code review. Patches that go through code review and are approved are generally merged quite quickly.

If this patch were reviewed - other than for technical correctness and coding guidelines - there are two points that would probably be raised:
# It could use some tests.
# Generally, the correct way to fix this problem is to implement pre-dial handlers for the Originate application. That allows modification of the outbound channel for any reason, as opposed to passing more parameters into the application itself. It also fixes the problem of "what should be on this outbound channel" once and for all.



> [patch]Asterisk app_originate doesn't allow setting Caller*ID on the originating channel
> ----------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-22992
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22992
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_originate
>    Affects Versions: 12.0.0-beta2
>            Reporter: Anthony Messina
>            Severity: Minor
>         Attachments: asterisk-12-app_originate_callerid.patch
>
>
> Using Originate via the dialplan to "invite" additional parties to an in progress ConfBridge, one is unable to provide Caller*ID on the originating channel.
> Basing my overly-simplistic work on another user trying to fix the same issue (https://github.com/cmendes0101/asterisk-originate-callerid), I have attached a patch to at least enable setting Caller*ID name and number.
> I realize that is is a TODO to allow variable passing through to the Originated channel and am hopeful this will get the ball rolling.



--
This message was sent by Atlassian JIRA
(v6.2#6252)