[asterisk-bugs] [JIRA] (ASTERISK-24572) App_meetme is loaded without its defaults when the configuration file is missing

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223800#comment-223800 ] 

Matt Jordan commented on ASTERISK-24572:
----------------------------------------

I'm not sure I agree with this patch.

With your patch, an invalid configuration file will cause the previous config file's settings to be reset to the default - but then fail to apply the new configuration. That could have some rather nasty consequences - for example, I may have {{logmembercount}} set to {{1}}, modify my config file such that is invalid, issue a reload, and now - instead of simply rejecting the configuration and preserving the previous value of {{logmembercount}} - it will set it to 0 and then fail the config file load.

That's worse behaviour than what we have now.

I do think you should try to fix this such that - on an initial load only - {{rt_log_members}} is set to {{1}}. But that should only apply on initial load, and not on a reload. On a reload, the previous values should always be preserved if the config file load fails.

> App_meetme is loaded without its defaults when the configuration file is missing
> --------------------------------------------------------------------------------
>
>                 Key: ASTERISK-24572
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24572
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_meetme
>            Reporter: Nuno Borges
>            Severity: Trivial
>         Attachments: 24572.patch
>
>
> We had some voice issues when using app_meetme rooms for conferences. We were not exporting the app_meetme configuration file assuming it would load the defaults anyway, but it didn't. Either the module fails to load due to the lack of the configuration file or it should always init its defaults.



--
This message was sent by Atlassian JIRA
(v6.2#6252)