[asterisk-bugs] [JIRA] (ASTERISK-24178) fromdomainport used even if not set

[Elazar Broad (JIRA)]

Elazar Broad created ASTERISK-24178:
---------------------------------------

             Summary: fromdomainport used even if not set
                 Key: ASTERISK-24178
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24178
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_sip/General
    Affects Versions: SVN
            Reporter: Elazar Broad
            Severity: Minor
         Attachments: fromdomainport_fix.diff

Long story short, we set fromdomainport to STANDARD_SIP_PORT if it is not set by the user in fromdomain(see http://doxygen.asterisk.org/trunk/df/df0/chan__sip_8c-source.html#l30599). The issue is, in two places, we do the following:

int ourport = (p->fromdomainport) ? p->fromdomainport : ast_sockaddr_port(&p->ourip);

Which means we will always use fromdomainport even if it wasn't actually set by the user. A side effect of this, is when using SIP over TLS, an MWI response will always include port 5060 in the Message-Account field even though TLS uses 5061 (see http://doxygen.asterisk.org/trunk/df/df0/chan__sip_8c-source.html#l15086). 

The attached patch resolves this issue. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)