[asterisk-bugs] [JIRA] (ASTERISK-24155) [patch]Non-portable and non-reliable recursion detection in ast_malloc

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221393#comment-221393 ] 

Rusty Newton commented on ASTERISK-24155:
-----------------------------------------

Thanks!  For this patch and the other you just filed, you'll want to go ahead and throw them on Reviewboard if possible, following the [Code Review|https://wiki.asterisk.org/wiki/display/AST/Code+Review] process.

> [patch]Non-portable and non-reliable recursion detection in ast_malloc
> ----------------------------------------------------------------------
>
>                 Key: ASTERISK-24155
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24155
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/General, Core/Portability
>    Affects Versions: 12.4.0
>            Reporter: Timo Teräs
>         Attachments: musl-outofmem-handling.patch
>
>
> Great care was earlier taken to not depend on execinfo.h's backtrace() which is non-portable. It was used if available, but it was not required. But now an unconditional core code dependency to it was added.
> This is also non-reliable on certain hardware architectures if the binary is fully stripped as there is no unwind information present. 
> Basically the function is used for purposes it should never be used for. Please replace the recursive call logic with something better. See attached patch for one suggestions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)