[asterisk-bugs] [JIRA] (ASTERISK-23679) CDR userfield merged incorrectly in ast_bridge_call

[Vitezslav Novy (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=217772#comment-217772 ] 

Vitezslav Novy commented on ASTERISK-23679:
-------------------------------------------

I don not think you are right in this : With this patch, however, it becomes "foo;yackity".

Correct value of concatenated userfied is created in tmp variable by sprintf.
No matter what was in A leg userfield, semicolon and B leg userfield is appended;
I do not see how 'bar' part from your example could disappear.
Only problem of the original code is that this correct value is appended to A leg userfield previous value.
It should be just set to A leg userfield.

Or am I overlooking something?

I believe this patch does not change anything about  CDR philosophy, it just try to fix incorrect manipulation with strings.
 


> CDR userfield merged incorrectly in ast_bridge_call 
> ----------------------------------------------------
>
>                 Key: ASTERISK-23679
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23679
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Features
>    Affects Versions: 11.9.0
>            Reporter: Vitezslav Novy
>            Severity: Minor
>         Attachments: 11-cdr_userfield.patch
>
>
> In function ast_bridge_call (in main/features.c) CDR field of B leg is appended to  CDR userfield of A leg.
> when at start userfield of leg A is 'aaa' and userfield of leg B is 'bbb' result in leg A userfield should be 'aaa;bbb'.
> Because of incorrect merge result is 'aaaaaa;bbb' 



--
This message was sent by Atlassian JIRA
(v6.2#6252)