[asterisk-bugs] [JIRA] (ASTERISK-23670) Monitor: Kill with Fire.

[Rusty Newton (JIRA)]

Rusty Newton created ASTERISK-23670:
---------------------------------------

             Summary: Monitor: Kill with Fire.
                 Key: ASTERISK-23670
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23670
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Resources/res_monitor
    Affects Versions: SVN
            Reporter: Matt Jordan


There's really no reason for Monitor any more. With MixMonitor's 'r' and 't' options, MixMonitor can perform everything Monitor does, and it does it in a much more effective fashion.

Problems with Monitor:
# It uses Optional API. Optional API breaks things.
# It still sits in {{channel.c}}. Every thing we do in {{ast_write}} takes time.
# It doesn't use framehooks.
# It is executed by the thread writing frames. Writing to disk on that thread is bad.

Rip it out. Kill with fire.

But don't break compatibility! Instead, res_monitor should map it's callbacks to app_mixmonitor. Or app_mixmonitor should just provide Monitor as well and call MixMonitor under the hood.

Features callbacks should do that as well.




--
This message was sent by Atlassian JIRA
(v6.2#6252)