[asterisk-bugs] [JIRA] (ASTERISK-13145) [patch] Presence subscription on Cisco SIP phone needs special Cisco-styled XML

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=217453#comment-217453 ] 

Matt Jordan commented on ASTERISK-13145:
----------------------------------------

There seems to be a large misconception here about how the Asterisk project works. There is no political question. The author of the patch is more than free to post these changes to review board and work to get them included into Asterisk trunk.

As a large patch with lots of ancillary changes that affect a substantial part of {{chan_sip}}, that is obviously a non-trivial amount of work to do. We encourage everyone to assist in that effort. That includes putting the code through review (given the size of the changes, in manageable chunks), as well as writing automated tests to verify that no regressions are introduced.

Note that anyone who has signed a license contributor agreement can post code to review board. As the author of the patch, Gareth would have to post the code and manage that process, although anyone who has signed a license contributor agreement can work with him to resolve findings.

This is the same process that *all* contributors to the project have to work through. We all post code in reasonable chunks (when the effort is large; for example, see the format work currently being done by Joshua Colp); we all write tests; we all do code reviews.

See [https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process] for more information.

> [patch] Presence subscription on Cisco SIP phone needs special Cisco-styled XML
> -------------------------------------------------------------------------------
>
>                 Key: ASTERISK-13145
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-13145
>             Project: Asterisk
>          Issue Type: New Feature
>          Components: Channels/chan_sip/NewFeature
>            Reporter: David McNett
>         Attachments: 01-btias.patch, 02-media-attrib-sdp.patch, 03-media-attrib-sdp-backport.patch, 04-imageattr.patch, 7965.xml, 8001 to 8003 and hangup.pcap, 8001 to 8003 and pickup then talk then hangup.pcap, asterisk-1.8.7.0-chan_sip.patch, backtrace.txt, Capture - CSO Presence - Lift and Replace Handset.pcap, Capture - CSO Presence - Ring between 2 monitored extensions.pcap, chan_sip.c_available_on-the-phone.patch, chan_sip.c_blf_available_on-the-phone.patch, chan_sip.c.patch, cisco-blf-asterisk.1.6.0.26.patch, cisco-blf-asterisk.1.6.2.13.patch, cisco-blf-asterisk.1.8.0.patch, core-ast115-sccp.tar.gz, gareth-10.6.0.patch, gareth-11.2.1-dndbusy.patch, gareth-11.7.0.patch, gareth-1.8.14.0.patch, gareth-featurepolicy.xml, gareth-mk-1.8.13.0.patch, gareth-softkeys.xml, gareth-softkeys.xml, memleak_astdb.patch, messages-1, Poly_reboot.log, rjw-11.4.0.patch, second-sip-trace-7941-9-1-1SR1.txt, sip-trace-7941-9-1-1SR1.txt, trace2.txt
>
>
> Cisco phones appear to be unable to parse the existing PIDF XML being generated by Asterisk for presence notification.  I've attached a patch which produces well-formed (but incomplete) XML which will satisfy a Cisco phone.  The patch as supplied will successfully render a "busy" subscription, but does not send a subsequent "available" notification, so presence detection only half works currently.
> I suspect the next step might be to watch some CallManager SIP traffic to identify precisely what XML tags the phone is expecting in order to properly parse an available subscription, but I'm not in a position to do that.  I'll continue to work with this, though, and perhaps may be able to stumble upon the precise data the Cisco phone is looking for.
> {{****** ADDITIONAL INFORMATION ******}}
> I believe that this requires the Cisco phones be configured to use SIP TCP when connecting to Asterisk.



--
This message was sent by Atlassian JIRA
(v6.2#6252)