[asterisk-bugs] [JIRA] (ASTERISK-23636) [patch]Filesystem based dynamic MoH classes

Matt Jordan (JIRA) noreply at issues.asterisk.org
Thu Apr 17 16:30:19 CDT 2014


    [ https://issues.asterisk.org/jira/browse/ASTERISK-23636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=217419#comment-217419 ] 

Matt Jordan commented on ASTERISK-23636:
----------------------------------------

This does need to be put up for code review; however, I don't think I like the implementation approach. It's very complex. If we're going to define such things, why wouldn't we just define a class within musiconhold.conf and within that class explicitly order and define the path of a file to be used?

Having users create a separate playlist file that's referenced from some other directory doesn't seem to offer a simple or robust solution. The playlist should simply be part of musiconhold.conf, and if a particular play control is needed, put a particular method as an attribute of a class.


> [patch]Filesystem based dynamic MoH classes
> -------------------------------------------
>
>                 Key: ASTERISK-23636
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23636
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Resources/res_musiconhold
>    Affects Versions: SVN
>            Reporter: Vitezslav Novy
>            Severity: Minor
>         Attachments: trunk-moh-20140415.patch
>
>
> This patch introduces another approach to dynamically controlled MoH.
> Unlike realtime this way is file based.
> As a switch between normal and alternative behavior, boolean variable
> 'dynamic' is used in MoH config file.
> By setting
> dynamic=yes
> new behavior is switched on.
> How dynamic behavior works
> All static MoH classes in musiconhold.conf and realtime are ignored, except [default]
> class. On the other hand dynamic class named 'default' is ignored too.
> New variable 'dynamic_dir' defines directory, where dynamic classes are
> defined. Each first level subdirectory of dynamic_dir defines one MoH class
> with same name as directory name.
> If class directory contains playlist file 'playlist.txt' content of
> the file defines audiofiles in class and their order. Otherwise directory
> is scanned same way as for standard MoH class with mode=files.
> Playlist expects one file on line, without path and without extension.
> Files must be placed in class directory.
> If first line of playlist contains exactly one character '%', files will be
> ordered randomly.



--
This message was sent by Atlassian JIRA
(v6.2#6252)



More information about the asterisk-bugs mailing list