[asterisk-bugs] [JIRA] (ASTERISK-23628) chan_unistim.c: 2 * bad if tests

[dcb314 (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=217290#comment-217290 ] 

dcb314 commented on ASTERISK-23628:
-----------------------------------

>We can't accept inline patches in issues, even if the patch is trivial. 

Righto.

>Please sign a license contributor agreement and attach the patch in unified diff format to this issue.

Sorry, no. 

I find bugs, other folks with more knowledge of the project are better placed to fix them.


> chan_unistim.c: 2 * bad if tests
> --------------------------------
>
>                 Key: ASTERISK-23628
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23628
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>         Environment: All
>            Reporter: dcb314
>            Assignee: dcb314
>
> [chan_unistim.c:1230]: (warning) Logical conjunction always evaluates to false: fav < 0 && fav > 5.
> Source code is
>     if ((fav < 0) && (fav > 5)) {
> \[EDIT: mjordan\]
> Removed inline patch.
> [chan_unistim.c:1244]: (warning) Logical conjunction always evaluates to false: fav < 0 && fav > 5.
> Duplicate.



--
This message was sent by Atlassian JIRA
(v6.2#6252)