[asterisk-bugs] [JIRA] (ASTERISK-23628) chan_unistim.c: 2 * bad if tests

[Matt Jordan (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-23628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Jordan updated ASTERISK-23628:
-----------------------------------

    Description: 
[chan_unistim.c:1230]: (warning) Logical conjunction always evaluates to false: fav < 0 && fav > 5.

Source code is

    if ((fav < 0) && (fav > 5)) {

\[EDIT: mjordan\]

Removed inline patch.

[chan_unistim.c:1244]: (warning) Logical conjunction always evaluates to false: fav < 0 && fav > 5.

Duplicate.


  was:
[chan_unistim.c:1230]: (warning) Logical conjunction always evaluates to false: fav < 0 && fav > 5.

Source code is

    if ((fav < 0) && (fav > 5)) {

Suggest new code

    if ((fav < 0) || (fav > 5)) {

[chan_unistim.c:1244]: (warning) Logical conjunction always evaluates to false: fav < 0 && fav > 5.

Duplicate.



> chan_unistim.c: 2 * bad if tests
> --------------------------------
>
>                 Key: ASTERISK-23628
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23628
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>         Environment: All
>            Reporter: dcb314
>
> [chan_unistim.c:1230]: (warning) Logical conjunction always evaluates to false: fav < 0 && fav > 5.
> Source code is
>     if ((fav < 0) && (fav > 5)) {
> \[EDIT: mjordan\]
> Removed inline patch.
> [chan_unistim.c:1244]: (warning) Logical conjunction always evaluates to false: fav < 0 && fav > 5.
> Duplicate.



--
This message was sent by Atlassian JIRA
(v6.2#6252)