[asterisk-bugs] [JIRA] (ASTERISK-23545) Confbridge talker detection settings configuration load bug

[Richard Mudgett (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-23545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Mudgett updated ASTERISK-23545:
---------------------------------------

    Description: 
When dsp_talking_threshold and dsp_silence_threshold are loaded from the Confbridge config they both appear to be written to silence_threshold attribute of the user profile.

This has the effect of the user not being able to change the talking_threshold, and the silence_threshold is incorrectly set to the talking threshold too.

What appears to be the erroneous line is in apps/confbridge/conf_config_parser.c
{noformat}
aco_option_register(&cfg_info, "dsp_silence_threshold", ACO_EXACT, user_types, __stringify(DEFAULT_SILENCE_THRESHOLD), OPT_UINT_T, 0, FLDSET(struct user_profile, silence_threshold));
aco_option_register(&cfg_info, "dsp_talking_threshold", ACO_EXACT, user_types, __stringify(DEFAULT_TALKING_THRESHOLD), OPT_UINT_T, 0, FLDSET(struct user_profile, silence_threshold));
{noformat}

The obvious fix is to change the second silence_threshold to talking_threshold in the snippet above. My license agreement hasn't been finalised yet so I can't submit a patch .

  was:
When dsp_talking_threshold and dsp_silence_threshold are loaded from the Confbridge config they both appear to be written to silence_threshold attribute of the user profile.

This has the effect of the user not being able to change the talking_threshold, and the silence_threshold is incorrectly set to the talking threshold too.

What appears to be the erroneous line is in apps/confbridge/conf_config_parser.c

aco_option_register(&cfg_info, "dsp_silence_threshold", ACO_EXACT, user_types, __stringify(DEFAULT_SILENCE_THRESHOLD), OPT_UINT_T, 0, FLDSET(struct user_profile, silence_threshold));
aco_option_register(&cfg_info, "dsp_talking_threshold", ACO_EXACT, user_types, __stringify(DEFAULT_TALKING_THRESHOLD), OPT_UINT_T, 0, FLDSET(struct user_profile, silence_threshold));

The obvious fix is to change the second silence_threshold to talking_threshold in the snippet above. My license agreement hasn't been finalised yet so I can't submit a patch .


> Confbridge talker detection settings configuration load bug
> -----------------------------------------------------------
>
>                 Key: ASTERISK-23545
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23545
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_confbridge
>    Affects Versions: SVN, 11.8.1
>            Reporter: John Knott
>            Severity: Minor
>
> When dsp_talking_threshold and dsp_silence_threshold are loaded from the Confbridge config they both appear to be written to silence_threshold attribute of the user profile.
> This has the effect of the user not being able to change the talking_threshold, and the silence_threshold is incorrectly set to the talking threshold too.
> What appears to be the erroneous line is in apps/confbridge/conf_config_parser.c
> {noformat}
> aco_option_register(&cfg_info, "dsp_silence_threshold", ACO_EXACT, user_types, __stringify(DEFAULT_SILENCE_THRESHOLD), OPT_UINT_T, 0, FLDSET(struct user_profile, silence_threshold));
> aco_option_register(&cfg_info, "dsp_talking_threshold", ACO_EXACT, user_types, __stringify(DEFAULT_TALKING_THRESHOLD), OPT_UINT_T, 0, FLDSET(struct user_profile, silence_threshold));
> {noformat}
> The obvious fix is to change the second silence_threshold to talking_threshold in the snippet above. My license agreement hasn't been finalised yet so I can't submit a patch .



--
This message was sent by Atlassian JIRA
(v6.2#6252)