[asterisk-bugs] [JIRA] (ASTERISK-22428) [patch] SIP unregister does not fully unregister when using Realtime sip peers

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210338#comment-210338 ] 

Michael L. Young edited comment on ASTERISK-22428 at 9/17/13 1:42 PM:
----------------------------------------------------------------------

Okay, what I found out was my tests (sipp scenarios) had some flaws.  Once that was worked out the tests failed without the patch, as is expected, and Asterisk responded the same way whether it was an authenticated register or not.

There seems to be two issues here.  One dealing with Realtime SIP peers having the database record updated (putting back what was just cleared out) after the peers have been unregistered and one dealing with the handling of the Expires header.

Therefore, I have updated the patch accordingly to hopefully handle both of these issues.  Please test it, [^asterisk-22428-rt-peer-update-and-expires-header.diff], and report back if you can.  It would be greatly appreciated.

Thanks
                
      was (Author: elguero):
    Okay, what I found out was my tests (sipp scenarios) had some flaws.  Once that was worked out the tests failed without the patch, as is expected, and Asterisk responded the same way whether it was an authenticated register or not.

There seems to be two issues here.  One dealing with Realtime SIP peers having the database record updated (putting back what was just cleared out) after the peers have been unregistered and one dealing with the handling of the Expires header.

Therefore, I have updated the patch accordingly to hopefully handle both of these issues.  Please test it and report back if you can.  It would be greatly appreciated.

Thanks
                  
> [patch] SIP unregister does not fully unregister when using Realtime sip peers
> ------------------------------------------------------------------------------
>
>                 Key: ASTERISK-22428
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22428
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/Registration
>    Affects Versions: 1.8.23.0, 11.5.0
>            Reporter: Ben Smithurst
>            Assignee: Michael L. Young
>            Severity: Minor
>         Attachments: after.pcap, asterisk-22428-dont-update-unregistered-peer.diff, asterisk-22428-rt-peer-update-and-expires-header.diff, before.pcap, console_after.txt, console_before.txt, realtime_unregister.diff
>
>
> When a SIP phone unregisters, this does not seem to be fully saved back to the DB when using realtime.  I see that the ipaddr and port fields are cleared, but regseconds and fullcontact are not, so the registration still works.  Asterisk seems to know it is unregistering, as it logs 'Unregistering SIP xxx' on the console.
> In console_before.txt you can see that after unregister, a call is placed, and the call is routed to the extension, but in console_after.txt it immediately says everyone is busy/congested, as expected.
> I have also attached before/after PCAPs and the simple patch I have used to solve this.  The problem is present, and the patch works, in both 11.5.0, and the head of branches/11 (SVN-branch-11-r397758).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira