[asterisk-bugs] [JIRA] (ASTERISK-17273) [patch] - Incorrect address specified in SIP re-INVITE with T.38 when directmedia enabled

[Kevin Stewart (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-17273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210105#comment-210105 ] 

Kevin Stewart commented on ASTERISK-17273:
------------------------------------------

The changes that are made are to move the doing_directmedia check outside the add_audio block so it can be used when we are renegotiating to T38 and doing direct media.

All my other changes do is copy information from the incoming SDP to the outgoing SDP if we are doing Direct media so the 2 end points can negotiate injecting our t38 config into the SDP would be bad.

If we are doing direct media append m=image with the port received.
If we are doing direct media append T38MaxBitRate received from incoming SDP else use our settings.
If we are doing direct media append T38FaxMaxDatagram received from incoming SDP else use our settings.

Also when parsing SDP ASSUME that their_parms.rate defaults to 14400 if not passed (cisco PGW does not pass any params :/ ) else we will pass this as 0 this would also be bad.
                
> [patch] - Incorrect address specified in SIP re-INVITE with T.38 when directmedia enabled
> -----------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-17273
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-17273
>             Project: Asterisk
>          Issue Type: Bug
>          Components: Channels/chan_sip/T.38
>            Reporter: dario
>            Assignee: Kevin Stewart
>            Severity: Minor
>         Attachments: chan_sip.c.patch, sip.conf, t38_reinvite_problem.txt
>
>
> T.38 reinvite doesn't work when directmedia is enabled. VoIP Gateway initiates t.38 reinvnite with ip a.b.c.d and port x, but asterisk forwards this invite to other Gateway with ip a.b.c.d and port y in SDP. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira