[asterisk-bugs] [JIRA] (ASTERISK-22347) [patch]res_xmpp timeout when google sends blank responses ' '

Kinsey Moore (JIRA) noreply at issues.asterisk.org
Mon Sep 9 08:15:03 CDT 2013


    [ https://issues.asterisk.org/jira/browse/ASTERISK-22347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210059#comment-210059 ] 

Kinsey Moore commented on ASTERISK-22347:
-----------------------------------------

Andrew,
Sorry for the lack of communication here. On Friday, I went ahead and addressed the issues raised on this on reviewboard, addressed some issues that I found, and got this committed to 11, 12, and trunk.
                
> [patch]res_xmpp timeout when google sends blank responses ' '
> -------------------------------------------------------------
>
>                 Key: ASTERISK-22347
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22347
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_xmpp
>    Affects Versions: 11.5.0
>         Environment: CentOS 6.4
>            Reporter: Andrew Nagy
>            Assignee: Kinsey Moore
>            Severity: Minor
>         Attachments: xmpp_fix_1.diff
>
>
> Sometimes the Google Voice servers have a bad habit of sending out 1 byte replies to the xmpp resource. When a blank 1 byte reply is received from the socket the buffer attempts to wait (endlessly) for the rest of the reply from google. 
> This effectively blocks the socket and google voice calls will no longer come into the server. 
> This patch allows the xmpp module to correctly detect empty packets and send out ping replies to google. It also sets a socket timeout on the default socket which prevents the xmpp socket from closing and preventing future google voice calls from coming into the server. 
> Furthermore instead of sending an empty reply back to google we send a proper xmpp ping reply back. Finally I have also added several more socket messages (near the end)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



More information about the asterisk-bugs mailing list