[asterisk-bugs] [JIRA] (ASTERISK-22480) Asterisk 11 pjproject: build.mak contains hardcoded full path to version.mak

[Corey Farrell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210051#comment-210051 ] 

Corey Farrell edited comment on ASTERISK-22480 at 9/9/13 3:26 AM:
------------------------------------------------------------------

I've removed the patch with relative directories as it actually made embedding slightly more difficult.
                
      was (Author: coreyfarrell):
    It appears relative paths do work.  I just repeated the same tests with this new patch.

Relative paths also removes a hack from my patch for embedding res_rtp_asterisk in asterisk 11.
                  
> Asterisk 11 pjproject: build.mak contains hardcoded full path to version.mak
> ----------------------------------------------------------------------------
>
>                 Key: ASTERISK-22480
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22480
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/BuildSystem
>    Affects Versions: 11.5.1
>            Reporter: Matt Jordan
>         Attachments: pjproject-11-realpath.patch
>
>
> After an initial {{configure}}, pjproject (in {{res/pjproject/build.mak}}) will embed the full path to version.mak:
> {noformat}
> export PJDIR := /srv/bamboo/xml-data/build-dir/AST-ATRUNKFULLBUILD3-C632BB/asterisk/res/pjproject
> include $(PJDIR)/version.mak
> {noformat}
> This is done in {{build.mak.in}}:
> {noformat}
> export PJDIR := @ac_pjdir@
> include $(PJDIR)/version.mak
> export PJ_DIR := $(PJDIR)
> {noformat}
> Not using a relative path is okay; however, if the directory of Asterisk is moved, Asterisk will no longer compile. Worse, a {{make clean}} or {{make distclean}} won't fix the issue as the make target itself is borked:
> {noformat}
> mjordan at asterisk-testsuite-32-centos:/srv/bamboo/xml-data/build-dir/AST-ATRUNKUNIT3-C632UT/asterisk$ sudo make distclean
> [sudo] password for mjordan: 
> build.mak:2: /srv/bamboo/xml-data/build-dir/AST-ATRUNKFULLBUILD3-C632BB/asterisk/res/pjproject/version.mak: No such file or directory
> make[2]: *** No rule to make target `/srv/bamboo/xml-data/build-dir/AST-ATRUNKFULLBUILD3-C632BB/asterisk/res/pjproject/version.mak'.  Stop.
> make[1]: *** [clean] Error 2
> make: *** [res-dist-clean] Error 2
> mjordan at asterisk-testsuite-32-centos:/srv/bamboo/xml-data/build-dir/AST-ATRUNKUNIT3-C632UT/asterisk$ 
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira