[asterisk-bugs] [JIRA] (ASTERISK-22466) chan_dahdi allows for updating both hw and sw gains, but dahdi show channel doesn't reflect changes

[Rusty Newton (JIRA)]

Rusty Newton created ASTERISK-22466:
---------------------------------------

             Summary: chan_dahdi allows for updating both hw and sw gains, but dahdi show channel doesn't reflect changes
                 Key: ASTERISK-22466
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22466
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_dahdi
    Affects Versions: 11.5.0
            Reporter: Jaco Kroon
            Severity: Minor


I think some output explains it best:

# asterisk -Rx "dahdi show channel 3" | grep Gains
Gains (RX/TX): 8.00/6.00
# asterisk -rx "dahdi set swgain rx 3 4.0"
software rx gain set to 4.0 on channel 3
# asterisk -Rx "dahdi show channel 3" | grep Gains
Gains (RX/TX): 8.00/6.00

So in spite of the gain having being modified the change is not reflected.  There is also no indication whether the displayed gains is the hw or sw gains.

I've written a small patch to rectify the situation and improve it somewhat:


# asterisk -Rx "dahdi show channel 3" | grep Gains
SW Gains (RX/TX): 8.00/6.00
HW Gains (RX/TX): 0.00/0.00
# asterisk -rx "dahdi set swgain rx 3 4.0"
software rx gain set to 4.0 on channel 3
# asterisk -Rx "dahdi show channel 3" | grep Gains
SW Gains (RX/TX): 4.00/6.00
HW Gains (RX/TX): 0.00/0.00

There is a secondary (and actually more significant) problem here:

The hw gains are not initialized during startup/reload at all (at least, not as far as I can tell).  And if they're already set during reload/restart the only way that I can see to get them back to some pre-configured value is to explicitly reset them using "dahdi set hwgain".  This patch assumes that they are zeroed during startup/reload (which can be false).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira