[asterisk-bugs] [JIRA] (ASTERISK-22429) [patch] - chan_dahdi allows for updating both hw and sw gains, but dahdi show channel doesn't reflect changes

[Jaco Kroon (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210841#comment-210841 ] 

Jaco Kroon commented on ASTERISK-22429:
---------------------------------------

Richard,

I can appreciate that, points 2 and 3 seems conflicting however (possibly grammer in 2 that's tripping me up).  I assume you're referring to these parameters in the wctdm24xxp module:

parm:           fxotxgain:int
parm:           fxorxgain:int
parm:           fxstxgain:int
parm:           fxsrxgain:int

This is not a granular per channel setting.

Either which way - either the control of hwgains should be removed entirely, or at least the patch needs to be applied, but preferably more needs to be done in order to allow setting hwgain for those cards that support it from the config file too.

The ability to set the hw gains on a per channel basis is definitely useful in my personal opinion and I'd rather see the functionality *added* to asterisk than removing the hwgain functionality entirely.  But that's just me.
                
> [patch] - chan_dahdi allows for updating both hw and sw gains, but dahdi show channel doesn't reflect changes
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-22429
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22429
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_dahdi
>    Affects Versions: 11.5.0
>            Reporter: Jaco Kroon
>            Assignee: Richard Mudgett
>            Severity: Minor
>         Attachments: asterisk-11.5.0-dahdi_gain_display.diff
>
>
> I think some output explains it best:
> # asterisk -Rx "dahdi show channel 3" | grep Gains
> Gains (RX/TX): 8.00/6.00
> # asterisk -rx "dahdi set swgain rx 3 4.0"
> software rx gain set to 4.0 on channel 3
> # asterisk -Rx "dahdi show channel 3" | grep Gains
> Gains (RX/TX): 8.00/6.00
> So in spite of the gain having being modified the change is not reflected.  There is also no indication whether the displayed gains is the hw or sw gains.
> I've written a small patch to rectify the situation and improve it somewhat:
> # asterisk -Rx "dahdi show channel 3" | grep Gains
> SW Gains (RX/TX): 8.00/6.00
> HW Gains (RX/TX): 0.00/0.00
> # asterisk -rx "dahdi set swgain rx 3 4.0"
> software rx gain set to 4.0 on channel 3
> # asterisk -Rx "dahdi show channel 3" | grep Gains
> SW Gains (RX/TX): 4.00/6.00
> HW Gains (RX/TX): 0.00/0.00
> There is a secondary (and actually more significant) problem here:
> The hw gains are not initialized during startup/reload at all (at least, not as far as I can tell).  And if they're already set during reload/restart the only way that I can see to get them back to some pre-configured value is to explicitly reset them using "dahdi set hwgain".  This patch assumes that they are zeroed during startup/reload (which can be false).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira