[asterisk-bugs] [JIRA] (ASTERISK-22897) WebSocket connection from JsSIP or SIPML5 generate a segmentation fault(core dumped)

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=212176#comment-212176 ] 

Matt Jordan commented on ASTERISK-22897:
----------------------------------------

I'm fairly sure that the code used by {{security_events}} is not going to work finding out whether or not a WS/WSS transport is in use:

{noformat}
static int find_transport_in_use(void *obj, void *arg, int flags)
{
	struct ast_sip_transport *transport = obj;
	pjsip_rx_data *rdata = arg;

	if ((transport->state->transport == rdata->tp_info.transport) ||
		(transport->state->factory && !pj_strcmp(&transport->state->factory->addr_name.host, &rdata->tp_info.transport->local_name.host) &&
			transport->state->factory->addr_name.port == rdata->tp_info.transport->local_name.port)) {
		return CMP_MATCH | CMP_STOP;
	}

	return 0;
}
{noformat}

Regardless, we shouldn't just dereference a NULL pointer. If the transport is unknown, it should just return "unknown".
                
> WebSocket connection from JsSIP or SIPML5 generate a segmentation fault(core dumped)
> ------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-22897
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22897
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip
>    Affects Versions: 12.0.0-beta1
>         Environment: Fedora 17, Linux version 3.8.11-100.fc17.x86_64
>            Reporter: Max E. Reyes Vera J.
>            Severity: Minor
>         Attachments: backtrace.txt
>
>
> Every time a websocket connection came from jssip or sipml5 asterisk crashes with the core dumped
> Here is the output of the backtrace--->http://pastebin.com/48gRGM4f
> Note: Asterisk was compiled with debugh_threads,better_backtraces and dont_optimize however there is the value <optimized out> in the backtrace.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira