[asterisk-bugs] [JIRA] (ASTERISK-21826) Bad queue_log entry when removed member from queue via CLI

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=206831#comment-206831 ] 

Michael L. Young edited comment on ASTERISK-21826 at 5/28/13 11:01 AM:
-----------------------------------------------------------------------

Fix patch


[edit: removed inline patch]
                
      was (Author: oscares):
    Fix patch


Index: apps/app_queue.c
===================================================================
--- apps/app_queue.c	(revisión: 389842)
+++ apps/app_queue.c	(copia de trabajo)
@@ -9226,11 +9226,12 @@
 	queuename = a->argv[5];
 	interface = a->argv[3];
 
+        if (log_membername_as_agent) {
+                mem = find_member_by_queuename_and_interface(queuename, interface);
+        }
+
 	switch (remove_from_queue(queuename, interface)) {
 	case RES_OKAY:
-		if (log_membername_as_agent) {
-			mem = find_member_by_queuename_and_interface(queuename, interface);
-		}
 		if (!mem || ast_strlen_zero(mem->membername)) {
 			ast_queue_log(queuename, "CLI", interface, "REMOVEMEMBER", "%s", "");
 		} else {

                  
> Bad queue_log entry when removed member from queue via CLI
> ----------------------------------------------------------
>
>                 Key: ASTERISK-21826
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21826
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_queue
>    Affects Versions: SVN
>         Environment: Asterisk SVN-trunk-r389827 currently running on debian
>            Reporter: Oscar Esteve
>
> If log_membername_as_agent is set to yes at queues.conf to report the queuemember name instead the member interface, when added a member with CLI:
> *CLI> queue add member SIP/oscar to markq penalty 1 as oscar
> Added interface 'SIP/oscar' to queue 'markq'
> queue_log entry:
> 1369682091|CLI|markq|oscar|ADDMEMBER|
> And when removed it:
> *CLI> queue remove member SIP/oscar from markq
> Removed interface SIP/oscar from queue 'markq'
> queue_log entry:
> 1369682167|CLI|markq|SIP/oscar|REMOVEMEMBER|
> note the queuemember field is really the interface not the queuename.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira