[asterisk-bugs] [JIRA] (ASTERISK-21809) Not proper sip_pvt::novideo and sip_pvt::notext init

[Roman S. (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-21809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman S. updated ASTERISK-21809:
--------------------------------

    Description: 
{{sip_pvt::novideo}} and {{sip_pvt::notext}} is being reset to default value in {{process_sdp()}}:

{noformat}
 9265         /* default: novideo and notext set */                                                     
 9266         p->novideo = TRUE;                                                                        
 9267         p->notext = TRUE;    
{noformat}

But in case of re-INVITE with the same SDP version:

{noformat}
 9281                         /* If we end up receiving SDP that doesn't actually modify the session we don't want to treat this as a fatal
 9282                          * error. We just want to ignore the SDP and let the rest of the packet be handled as normal.
 9283                          */                                                                       
 9284                         if (!process_sdp_o(value, p)) {                                           
 9285                                 return (p->session_modify == FALSE) ? 0 : -1;
{noformat}

 values of mentioned variables stay default. This isn't correct in case if video is present (already established). As result Asterisk sends 200 OK answer with audio only media.

I suppose that it's better to set variables to default values in {{sip_alloc()}}

  was:
{{sip_pvt::novideo}} and {{sip_pvt::notext}} is being reset to default value in {{process_sdp()}}:

{noformat}
 9265         /* default: novideo and notext set */                                                     
 9266         p->novideo = TRUE;                                                                        
 9267         p->notext = TRUE;    
{noformat}

But in case of re-INVITE with the same SDP version:

{noformat}
 9281                         /* If we end up receiving SDP that doesn't actually modify the session we don't want to treat this as a fatal
 9282                          * error. We just want to ignore the SDP and let the rest of the packet be handled as normal.
 9283                          */                                                                       
 9284                         if (!process_sdp_o(value, p)) {                                           
 9285                                 return (p->session_modify == FALSE) ? 0 : -1;
{noformat}

 values of mentioned variables stay default. This isn't correct in case if video is present (already established). As result Asterisk sends 200 OK answer with audio only media.

    
> Not proper sip_pvt::novideo and sip_pvt::notext init
> ----------------------------------------------------
>
>                 Key: ASTERISK-21809
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21809
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/Video
>    Affects Versions: 1.8.22.0
>            Reporter: Roman S.
>            Severity: Minor
>
> {{sip_pvt::novideo}} and {{sip_pvt::notext}} is being reset to default value in {{process_sdp()}}:
> {noformat}
>  9265         /* default: novideo and notext set */                                                     
>  9266         p->novideo = TRUE;                                                                        
>  9267         p->notext = TRUE;    
> {noformat}
> But in case of re-INVITE with the same SDP version:
> {noformat}
>  9281                         /* If we end up receiving SDP that doesn't actually modify the session we don't want to treat this as a fatal
>  9282                          * error. We just want to ignore the SDP and let the rest of the packet be handled as normal.
>  9283                          */                                                                       
>  9284                         if (!process_sdp_o(value, p)) {                                           
>  9285                                 return (p->session_modify == FALSE) ? 0 : -1;
> {noformat}
>  values of mentioned variables stay default. This isn't correct in case if video is present (already established). As result Asterisk sends 200 OK answer with audio only media.
> I suppose that it's better to set variables to default values in {{sip_alloc()}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira