[asterisk-bugs] [JIRA] (ASTERISK-21799) Dropouts/distortion in MixMonitor recording when recording RTP with ptime of 60ms

[Michael Walton (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-21799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Walton updated ASTERISK-21799:
--------------------------------------

    Description: 
When using MixMonitor to record a SIP call with ptime 60ms (possibly others also), the recording of one of the directions is heavily distorted due to repeated discontinuities in the recorded stream. Rate of dropout is 10-20 times per second. 

The bug has been found in main/slinfactory.c and exists in at least 1.8 and 11 SVN revisions. The problem is a clear bug in the hold buffer logic in ast_slinfactory_read(). The attached patch fixes the problem by using the current offset sf->offset instead of the start of the hold buffer as the source for memcpy'ing data to the  read buffer.

  was:
When using MixMonitor to record a SIP call with ptime 60ms (possibly others also), the recording of one of the directions is heavily distorted due to repeated discontinuities in the recorded stream. Rate of dropout is 10-20 times per second. 

The bug has been found in main/slinfactory.c and exists in at least 1.8 and 11 SVN revisions. The problem is a clear bug in the hold buffer logic in ast_slinfactory_read(). The attached patch fixes the problem by using the 

    
> Dropouts/distortion in MixMonitor recording when recording RTP with ptime of 60ms
> ---------------------------------------------------------------------------------
>
>                 Key: ASTERISK-21799
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21799
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_mixmonitor
>    Affects Versions: 11.4.0
>         Environment: Ubuntu 10.04.4 LTS
>            Reporter: Michael Walton
>            Severity: Minor
>         Attachments: slinfactory.c.ASTERISK-21799.patch
>
>
> When using MixMonitor to record a SIP call with ptime 60ms (possibly others also), the recording of one of the directions is heavily distorted due to repeated discontinuities in the recorded stream. Rate of dropout is 10-20 times per second. 
> The bug has been found in main/slinfactory.c and exists in at least 1.8 and 11 SVN revisions. The problem is a clear bug in the hold buffer logic in ast_slinfactory_read(). The attached patch fixes the problem by using the current offset sf->offset instead of the start of the hold buffer as the source for memcpy'ing data to the  read buffer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira