[asterisk-bugs] [JIRA] (ASTERISK-21772) Code reading revealed useless if statement

[Michael L. Young (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-21772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael L. Young updated ASTERISK-21772:
----------------------------------------

    Description: 
In code reading dns.c I see this:

                if (len < 0) {
                        ast_log(LOG_WARNING, "Strange result size\n");
                        return -1;
                }
                if (len < 0) {
                        ast_log(LOG_WARNING, "Length exceeds frame\n");
                        return -1;
                }

1. the second if will always be false if it's called
2. adds useless check, since first already covers it

I don't see a patch upload field here so here goes the patch:


[edit: removed inline patch]

  was:
In code reading dns.c I see this:

                if (len < 0) {
                        ast_log(LOG_WARNING, "Strange result size\n");
                        return -1;
                }
                if (len < 0) {
                        ast_log(LOG_WARNING, "Length exceeds frame\n");
                        return -1;
                }

1. the second if will always be false if it's called
2. adds useless check, since first already covers it

I don't see a patch upload field here so here goes the patch:


--- dns.c.orig  Thu May  9 10:06:09 2013
+++ dns.c       Thu May  9 10:06:50 2013
@@ -221,13 +221,13 @@
                }
                answer += res;
                len -= res;
-               ans = (struct dn_answer *)answer;
-               answer += sizeof(struct dn_answer);
-               len -= sizeof(struct dn_answer);
                if (len < 0) {
                        ast_log(LOG_WARNING, "Strange result size\n");
                        return -1;
                }
+               ans = (struct dn_answer *)answer;
+               answer += sizeof(struct dn_answer);
+               len -= sizeof(struct dn_answer);
                if (len < 0) {
                        ast_log(LOG_WARNING, "Length exceeds frame\n");
                        return -1;




    
> Code reading revealed useless if statement
> ------------------------------------------
>
>                 Key: ASTERISK-21772
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21772
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>    Affects Versions: SVN
>            Reporter: Peter J. Philipp
>            Severity: Minor
>
> In code reading dns.c I see this:
>                 if (len < 0) {
>                         ast_log(LOG_WARNING, "Strange result size\n");
>                         return -1;
>                 }
>                 if (len < 0) {
>                         ast_log(LOG_WARNING, "Length exceeds frame\n");
>                         return -1;
>                 }
> 1. the second if will always be false if it's called
> 2. adds useless check, since first already covers it
> I don't see a patch upload field here so here goes the patch:
> [edit: removed inline patch]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira