[asterisk-bugs] [JIRA] (ASTERISK-21036) Error in filename for jb log for DAHDI

[Rusty Newton (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-21036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rusty Newton updated ASTERISK-21036:
------------------------------------

    Description: 
DAHDI channels have two slashes, so both must be changed to '#' when forming the filename for the jitterbuffer log.

*_edited* Removed inline patch_

[Edit by Rusty Newton - adding quote from Richard's comment and the code I believe he's talking about]
"Please ignore the patch. If you look at the code that changes '/' to '#', you'll see that it's done (in two places) with an "if" statement. Changing the token "if" to "while" in both places will fix this issue."

{noformat}
                if ((tmp = strchr(name2, '/'))) {
                        *tmp = '#';
                }

                bridged = ast_bridged_channel(chan);
                /* We should always have bridged chan if a jitterbuffer is in use */
                ast_assert(bridged != NULL);

                snprintf(name1, sizeof(name1), "%s", ast_channel_name(bridged));
                if ((tmp = strchr(name1, '/'))) {
                        *tmp = '#';
                }
{noformat}

  was:
DAHDI channels have two slashes, so both must be changed to '#' when forming the filename for the jitterbuffer log.

*_edited* Removed inline patch_

Please ignore the patch. If you look at the code that changes '/' to '#', you'll see that it's done (in two places) with an "if" statement. Changing the token "if" to "while" in both places will fix this issue.

{noformat}
if ((tmp = strchr(name2, '/'))) {
                        *tmp = '#';
                }

                bridged = ast_bridged_channel(chan);
                /* We should always have bridged chan if a jitterbuffer is in use */
                ast_assert(bridged != NULL);

                snprintf(name1, sizeof(name1), "%s", ast_channel_name(bridged));
                if ((tmp = strchr(name1, '/'))) {
                        *tmp = '#';
                }

{noformat}

    
> Error in filename for jb log for DAHDI
> --------------------------------------
>
>                 Key: ASTERISK-21036
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21036
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/Jitterbuffer
>    Affects Versions: 10.7.1
>            Reporter: Richard Kenner
>            Assignee: Rusty Newton
>            Severity: Minor
>
> DAHDI channels have two slashes, so both must be changed to '#' when forming the filename for the jitterbuffer log.
> *_edited* Removed inline patch_
> [Edit by Rusty Newton - adding quote from Richard's comment and the code I believe he's talking about]
> "Please ignore the patch. If you look at the code that changes '/' to '#', you'll see that it's done (in two places) with an "if" statement. Changing the token "if" to "while" in both places will fix this issue."
> {noformat}
>                 if ((tmp = strchr(name2, '/'))) {
>                         *tmp = '#';
>                 }
>                 bridged = ast_bridged_channel(chan);
>                 /* We should always have bridged chan if a jitterbuffer is in use */
>                 ast_assert(bridged != NULL);
>                 snprintf(name1, sizeof(name1), "%s", ast_channel_name(bridged));
>                 if ((tmp = strchr(name1, '/'))) {
>                         *tmp = '#';
>                 }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira