[asterisk-bugs] [JIRA] (ASTERISK-17658) [patch] [regression] Blind transfers from queue are not logged into queue_log correctly

[Denis (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=204450#comment-204450 ] 

Denis commented on ASTERISK-17658:
----------------------------------

TRANSFER still not shown in queue_log in 1.8.20.1
                
> [patch] [regression] Blind transfers from queue are not logged into queue_log correctly
> ---------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-17658
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-17658
>             Project: Asterisk
>          Issue Type: Bug
>          Components: Applications/app_queue
>    Affects Versions: 1.8.7.0
>            Reporter: Grzegorz Garlewicz
>            Assignee: Matt Jordan
>         Attachments: app_queue.diff
>
>
> In 1.4 blind transfers from queue were correctly logged as TRANSFER. starting with 1.6.x they are no more logged as TRANSFER but as COMPLETEAGENT. I believe this is a regression related to issue 0014536. This was a fix for 1.4 merged into 1.6. It adds a test condition: !(qe->chan->_softhangup | peer->_softhangup). But in 1.4 peer->_softhangup was 1 during blind transfer and in 1.6.2 up peer->_softhangup is 0. This results in dead code for blind transfer logging. The trivial fix would be to revert 0014536-related changes (patch included) because when following issue pattern from 0014536 in 1.6.2 up this condition is no longer even tested. 
> The remaining question is if it is ok that peer->_softhangup is now 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira