[asterisk-bugs] [JIRA] (ASTERISK-21225) Setting nat=force_rport in [general] sip.conf will never work

[Walter Doekes (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=204108#comment-204108 ] 

Walter Doekes commented on ASTERISK-21225:
------------------------------------------

@elguero: Thanks for the explanation. Well yes. I think you should save that for a different patch.
(a) There is no problem in this bug that that change solves, and
(b) I would think that ast_sockaddr_cmp(&tmp, &p->recv) does what it's supposed to do.

If the cmp returns non-true then something would be wrong in the Via sent-by, and it's not at all bad that it goes into auto-rport mode. I'd file a different bug so we could examine why the first check doesn't catch the problem or decide that it's an UAC problem.
                
> Setting nat=force_rport in [general] sip.conf will never work
> -------------------------------------------------------------
>
>                 Key: ASTERISK-21225
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21225
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.2.1
>            Reporter: Alexandre Vezina
>            Assignee: Alexandre Vezina
>            Severity: Minor
>         Attachments: asterisk-21225-handle-options-default-prob_v2.diff
>
>
> I noticed that it was impossible to set nat=force_rport in the general section of sip.conf. It actually has no effect when issuing cli command "sip show settings" (result is Force rport: Auto (No).
> The function to reload configurations in chan_sip.c sets the flag SIP_PAGE3_NAT_AUTO_RPORT in the global flags and the function sip_parse_nat_option in config_parser.c will only add the flag SIP_NAT_FORCE_RPORT if SIP_PAGE3_NAT_AUTO_RPORT is not present.
> So, it seems impossible to raise the flag SIP_NAT_FORCE_RPORT in the [general] section of sip.conf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira